Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network December release #8163

Merged
merged 20 commits into from
Jan 15, 2020
Merged

Network December release #8163

merged 20 commits into from
Jan 15, 2020

Conversation

anton-evseev
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

anton-evseev and others added 20 commits November 6, 2019 16:23
@anton-evseev
Adds base for updating Microsoft.Network from version stable/2019-09-…
5547aae 
…01 to version 2019-11-01
@anton-evseev
Updates readme
32af3b1
@anton-evseev
Updates API version in new specs and examples
23f64a9
@anton-evseev @mmyyrroonn
Add missing spec reference in readme.md (Azure#7726)
bc43ac6
@solhaile @ChenTanyi
added username (Azure#7779)
09bdabc
@v-shhatt @ArcturusZhang
adding alisas to code owners file (Azure#7786)
8711f92
@v-shhatt @lirenhe
Committing changes to Fix Swagger descriptions to use "Reference to" … (
cf767ce 
Azure#7787)

* Committing changes to Fix Swagger descriptions to use "Reference to" instead of "Reference of"

* upgrade rest-api-specs-scripts version (Azure#7712)

* bump avocado version to support $(this-folder) (Azure#7743)

* regenerate package-lock.json (Azure#7756)

* Committing changes with formatted descriptions
@v-shhatt
Committing changes to remove verbs from Swagger descriptions (Azure#7788
dd5697e 
)

* Committing changes to remove verbs from Swagger descriptions

* upgrade rest-api-specs-scripts version (Azure#7712)

* bump avocado version to support $(this-folder) (Azure#7743)

* regenerate package-lock.json (Azure#7756)

* Committing changes as per review comments
@v-shhatt @erich-wang
committing changes to fix java sdk timeout issue (Azure#7802)
c9dd44f
@ssripadham @lirenhe
IpGroups reference in AzureFirewall (Azure#7807)
21d9358 
* IpGroups reference in AzureFirewall

* Fixed examples

* Committing changes to remove verbs from Swagger descriptions (Azure#7788)

* Committing changes to remove verbs from Swagger descriptions

* upgrade rest-api-specs-scripts version (Azure#7712)

* bump avocado version to support $(this-folder) (Azure#7743)

* regenerate package-lock.json (Azure#7756)

* Committing changes as per review comments

* committing changes to fix java sdk timeout issue (Azure#7802)

* IpGroups reference in AzureFirewall

* Fixed examples

* prettier fix

* prettier  --write
@ninweninwe
virtual wan/gateway disconnect vpn connections (Azure#7747)
653134d 
* virtual wan/gateway disconnect vpn connections

* fix the PR comments

* fix the PR

* upgrade rest-api-specs-scripts version (Azure#7712)

* bump avocado version to support $(this-folder) (Azure#7743)

* regenerate package-lock.json (Azure#7756)

* fix build error

* match class name with p2svpnconnectionrequest in nrp

* address the PR comments

* address the PR comments

* Prettify Network examples

* fix format of json
@iatodoro @lirenhe
Adding management IP configuration for Azure Firewall (Azure#7851)
06d3bee 
* Adding management IP configuration to firewall

* Changing description wording back

* Adding type property to AzureFirewallIpConfiguration

* Bumping API version in example files

* Fixing style issues

* Missed period at end of description
@irrogozh @akning-ms
Added connection monitor to networkWatcher swagger (Azure#7881)
bb87874 
* Added connection monitor to networkWatcher swagger

* Added tests for connection monitor

* Added NetworkWatcherConnectionMonitorUpdateTags test

* Removed reference on connectionMOnitorV1 in readme.md

* Suppressed DefinitionsPropertiesNamesCamelCase error

* Fixed warnings and added example cor connectionMonitorV2 creation

* Fixed formatting in NetworkWatcherConnectionMonitorV2Create test

* Added connectionMonitorType property to connectionMonitorResult

* Fixed networkWatcher swagger based on CR. Run prettier check

* Minor changes

* Run prettier check for networkWatcher
@damendo @njuCZ
Adding note about API (Azure#8104)
8ed1f05 
being in Preview
@amwate @njuCZ
Reverted express route changes brought in by Azure@a44f306#diff-2f0aa…
b351b58 
…6e57d2b97956e1fb54558cf4cdeR1714
@amwate @njuCZ
Reverted changes made by commit Azure@a44f306#diff-2f0aa6e57d2b97956e…
d53d584 
…1fb54558cf4cdeR1714
@abjai @lirenhe
Adding the structure of urlConfiguration in rewriteRuleActionSet (Azu…
ac7d32b 
…re#7905)

* Url Configuration swagger changes for Url Rewrite feature of Application Gateway

* prettier fix
@mancgupta @lirenhe
DDOS protected IP flag for public IP (Azure#8042)
6d14c40 
* DDOS protected IP flag for public IP

* Protected IP property in ddos setting

* fixing build errors

* Retriggering the build
@irrogozh @lirenhe
Added flowLog to NetworkWatcher swagger + examples (Azure#8025)
cc922ad 
* Added flowLog ro NetworkWatcher swagger + examples

* Cleaned up required properties for trafficAnalytics flow log

* Fixes based on CR
@anton-evseev
Network December release
2b5e6d5 
# Conflicts:
#	package.json
#	preproduction-azure-pipelines.yml
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akning-ms
Copy link
Contributor

As @number213 requested offline, it is urgent, help merge it.

@akning-ms akning-ms merged commit 5f99752 into Azure:master Jan 15, 2020
@anton-evseev anton-evseev mentioned this pull request Jan 15, 2020
Merged
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 15, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 15, 2020 •
edited
Loading

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2b5e6d5 with merge commit 5f99752. SDK Automation 13.0.17.20191226.1
  • ️✔️sdk/network/mgmt-v2019_02_01 [Logs]  [Release SDK Changes]
  • ⚠️sdk/network/mgmt-v2019_04_01 [Logs]  [Release SDK Changes] 
      [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
[mvn]   symbol:   method serviceName()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
[mvn]   symbol:   method serviceName()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
[mvn]   symbol:   method availableResourceGroupPrivateEndpointTypes()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
[mvn] [ERROR]   symbol:   method serviceName()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
[mvn] [ERROR]   symbol:   method serviceName()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
[mvn] [ERROR]   symbol:   method availableResourceGroupPrivateEndpointTypes()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ️✔️sdk/network/mgmt-v2019_06_01 [Logs]  [Release SDK Changes]
    • ️✔️sdk/network/mgmt-v2019_07_01 [Logs]  [Release SDK Changes]
    • ️✔️sdk/network/mgmt-v2019_08_01 [Logs]  [Release SDK Changes]
    • ⚠️sdk/network/mgmt-v2019_09_01 [Logs]  [Release SDK Changes] 
        [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
[mvn]   symbol:   class ResourceNavigationLinkInner
[mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
[mvn]   symbol:   class ServiceAssociationLinkInner
[mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
[mvn] [ERROR]   symbol:   class ResourceNavigationLinkInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
[mvn] [ERROR]   symbol:   class ServiceAssociationLinkInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jan 15, 2020 •
      edited
      Loading

      azure-sdk-for-net - Release

      🔄 inProgress [Logs] [Expand Details]
      • 🔄 Generate from 2b5e6d5 with merge commit 5f99752. SDK Automation 13.0.17.20191226.1

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jan 15, 2020 •
      edited
      Loading

      azure-sdk-for-python - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 2b5e6d5 with merge commit 5f99752. SDK Automation 13.0.17.20191226.1
      • ️✔️azure-mgmt-network [Logs]  [Release SDK Changes] 
        [after_scripts|python] WARNING:__main__:Found too much API version: {'2016-12-01', '2016-09-01'} in label v2016_12_01
[after_scripts|python] WARNING:__main__:Guessing you want 2016-12-01 based on label v2016_12_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-03-01'} in label v2017_03_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-03-01 based on label v2017_03_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-06-01'} in label v2017_06_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-06-01 based on label v2017_06_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-08-01'} in label v2017_08_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-08-01 based on label v2017_08_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-09-01'} in label v2017_09_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-09-01 based on label v2017_09_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2017-03-30'} in label v2017_10_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-10-01 based on label v2017_10_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-11-01'} in label v2017_11_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-11-01 based on label v2017_11_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-01-01'} in label v2018_01_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-01-01 based on label v2018_01_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-02-01', '2017-03-30'} in label v2018_02_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01 based on label v2018_02_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-04-01'} in label v2018_04_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-04-01 based on label v2018_04_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-06-01'} in label v2018_06_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-06-01 based on label v2018_06_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-07-01', '2017-03-30'} in label v2018_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-08-01'} in label v2018_08_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-08-01 based on label v2018_08_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-10-01'} in label v2018_10_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-10-01 based on label v2018_10_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-11-01', '2017-03-30'} in label v2018_11_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-11-01 based on label v2018_11_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-12-01'} in label v2018_12_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-12-01 based on label v2018_12_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-02-01', '2017-03-30'} in label v2019_02_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-02-01 based on label v2019_02_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2019-04-01'} in label v2019_04_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2019-06-01'} in label v2019_06_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01 based on label v2019_06_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01', '2019-07-01', '2018-10-01'} in label v2019_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-07-01 based on label v2019_07_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01', '2019-08-01', '2018-10-01'} in label v2019_08_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-08-01 based on label v2019_08_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-09-01', '2019-06-01', '2018-10-01'} in label v2019_09_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-09-01 based on label v2019_09_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jan 15, 2020 •
      edited
      Loading

      azure-sdk-for-js - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 2b5e6d5 with merge commit 5f99752. SDK Automation 13.0.17.20191226.1
      • ️✔️@azure/arm-network [Logs]  [Release SDK Changes] 
        [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
[npmPack] created ./dist/arm-network.js in 2.5s

      @anton-evseev anton-evseev deleted the merge-network-december branch March 23, 2020 10:15
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

      Assignees

      @raych1 raych1

      Labels
      None yet
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.